[PATCH] D58698: [DWARFFormValue] Don't consider DW_FORM_data4/8 to be section offsets.

[EsmeYi via Phabricator via llvm-commits]

Esme added a comment.
Herald added subscribers: sstefan1, cmtice, MaskRay.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: jhenderson.

Have you tested for DWARF3? It appears that you only added tests for DWARF2 and DWARF4.
And I noticed an error under DWARF3, where the C code source is the same as formclass4.s and formclass2.s.

  0x0000004e: DW_TAG_member
                DW_AT_name	("g")
                DW_AT_type	(0x00000079 "short")
                DW_AT_decl_file	("a.cpp")
                DW_AT_decl_line	(3)
                DW_AT_data_member_location	(0x00010000: error: offset 0x10000 is beyond the end of data at 0x23
  )


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58698/new/

https://reviews.llvm.org/D58698