[PATCH] D89009: Add version to libLLVM also on non-UNIX

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D89009#2857227 <https://reviews.llvm.org/D89009#2857227>, @mati865 wrote:

> In D89009#2857190 <https://reviews.llvm.org/D89009#2857190>, @mstorsjo wrote:
>
>> The import libraries do seem to use the right name as far as I can see, but there's another aspect I remembered now: This does create unversioned symlinks too (not while building but once you do `ninja install`). This probably is neat to have, but for cases when things are packaged up in e.g. zip files or something else that doesn't handle symlinks, one might want not to have them. Within llvm-mingw I guess I can have them stripped out before packaging though.
>
> Oh, nice. As for unversioned symlinks they would be changed into copies when packaging so we will remove them as well.

Yep. I guess the question mainly is if we'd want to make this an upstream thing, adding an `if(UNIX)` around the symlinks on lines 608-613 here, if windows packaging cases would want to omit them anyway?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009