[PATCH] D105364: [lld-macho] Drop assertions that all symbols are in GOT
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 4 13:09:24 PDT 2021
int3 added a subscriber: MaskRay.
int3 added a comment.
The motivation was from D105210 <https://reviews.llvm.org/D105210> -- the test case initially constructed while fixing PR50812 had symbol relocs in compact unwind, so I asked @oontvoo to split it out -- thanks for doing it :)
However, given that the cause of the bug is unrelated to N_STABS, I think we should have it in a different test file. Also, is this not something that we can test via assembly, instead of YAML?
Perhaps we should also rename the test (like @MaskRay suggested <https://reviews.llvm.org/rGbf7f846b683077a8adcb229624082e525870229b#1009321>) -- in addition to making it easier for the reader to understand context, it also encourages grouping tests by functionality tested, instead of by bug origin.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105364/new/
https://reviews.llvm.org/D105364
More information about the llvm-commits
mailing list