[PATCH] D89009: Add version to libLLVM also on non-UNIX

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D89009#2856933 <https://reviews.llvm.org/D89009#2856933>, @mati865 wrote:

> Thank you for returning to this.
> I'd love to get confirmation from @hans who suggested it in https://reviews.llvm.org/D87521 that this still seems like the best approach.
>
> I'll also need to recheck because I have no idea after all this time if import libraries have correct name (without the version) and do work.

The import libraries do seem to use the right name as far as I can see, but there's another aspect I remembered now: This does create unversioned symlinks too (not while building but once you do `ninja install`). This probably is neat to have, but for cases when things are packaged up in e.g. zip files or something else that doesn't handle symlinks, one might want not to have them. Within llvm-mingw I guess I can have them stripped out before packaging though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009