[PATCH] D89009: Add version to libLLVM also on non-UNIX

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 3 14:50:38 PDT 2021


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

This looks sensible to me (sorry for losing track of it earlier) as discussed in D87521 <https://reviews.llvm.org/D87521>.

I tried it out in a few setups to study it closer and it does seem to work safely. In practice no libraries that are built in MSVC configuration have `ARG_SONAME` set so this should have little to no effect on those configurations.

I can try to get it pushed in a couple days.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009



More information about the llvm-commits mailing list