[PATCH] D105315: [flang] Move External IO tests to use GTest

Sat Jul 3 11:18:49 PDT 2021

awarzynski added a subscriber: Meinersbur.
awarzynski added a comment.

This is the final patch to complete the porting of runtime unit tests to GTest. It's an important milestone!  @ashermancinelli, many thanks for seeing this through! I've compared `flang/unittests/Runtime/ExternalIOTest.cpp` and `flang/unittests/Runtime/external-io.cpp` - the semantics are identical and only the clang-tidy warnings need addressing before merging.

As for the failing CI tests - I can see that `external-io` is currently not being run on Windows: https://lab.llvm.org/staging/#/builders/179/builds/653/steps/7/logs/stdio. This suggests that this patch _exposes_ rather than _introduces_ these failures. I suspect that there is something Linux-specific about that test (file I/O?), but I can't see anything obvious. @Meinersbur set-up that Windows BuildBot worker - perhaps he'll have a suggestion? If we can't identify anything, `GTEST_SKIP` + bugzilla should be sufficient.

================
Comment at: flang/unittests/Runtime/ExternalIOTest.cpp:8
+//===----------------------------------------------------------------------===//
+
+#include "CrashHandlerFixture.h"
----------------
[nit] Perhaps add the original comment here: https://github.com/llvm/llvm-project/blob/main/flang/unittests/Runtime/external-io.cpp#L1. Just to make sure that everything is preserved.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105315/new/

https://reviews.llvm.org/D105315