[PATCH] D105382: [GlobalISel] Tail call memcpy/memmove/memset even in the presence of copies

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:548
+    Next = next_nodbg(Next, MBB.instr_end());
+  }
+
----------------
hm. This isn't quite right. It shouldn't be allowed to fire on this case:

```
    %0:_(p0) = COPY $x1
    %1:_(p0) = COPY $x0
    %2:_(s64) = COPY $x2
    G_MEMCPY %0(p0), %1(p0), %2(s64), 1 :: (store (s8)), (load (s8))
    $x1 = COPY %0(p0)
    RET_ReallyLR implicit $x0
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105382/new/

https://reviews.llvm.org/D105382