[PATCH] D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 2 15:55:46 PDT 2021


JDevlieghere added a comment.

In D104827#2855970 <https://reviews.llvm.org/D104827#2855970>, @dexonsmith wrote:

> That looks bad — best to revert while that's investigated.

This also breaks `lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py` in the LLDB test suite:

  Assertion failed: ((FromValue || !(isa<LocalAsMetadata>(MD) || isa<DIArgList>(MD))) && "Unexpected function-local metadata outside of value argument"), function WriteAsOperandInternal, file AsmWriter.cpp, line 2519.

Given that it's Friday, I'm going to go ahead and revert this to get our bot back to green.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104827/new/

https://reviews.llvm.org/D104827



More information about the llvm-commits mailing list