[PATCH] D105210: [lld-macho] Ignore debug symbols for now.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 2 15:53:51 PDT 2021


MaskRay added a comment.

I left two comments about the test bug_50812.s on https://reviews.llvm.org/rGbf7f846b683077a8adcb229624082e525870229b#1009321

I think someone may need to investigate how to improve ergonomics of Mach-O yaml2obj. Currently many properties need to be specified which makes a test very verbose and often hides interesting part among boilerplate.
The "address:" is also an issue. Inserting new code can invalid all address fields, making test updating unwieldly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105210/new/

https://reviews.llvm.org/D105210



More information about the llvm-commits mailing list