[PATCH] D105210: [lld-macho] Ignore debug symbols for now.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lld/test/MachO/bug_50812.s:6
+# RUN: yaml2obj %s -o %t.o
+# RUN: %lld -lSystem -platform_version macos 11.3 11.0 -arch x86_64 %t.o
+--- !mach-o
----------------
I fixed an issue with this test in bf7f846b683077a8adcb229624082e525870229b by adding `-o %t` to the lld RUN line - without that it tries to write the linked executable to the current working directory which may not be writable/may not be suitable to write to. (might be the test source directory, for instance)

But also: This test should probably verify something about the output of the lld execution - currently this test checks for "does anything so long as it exits 0" - perhaps it should check the specific behavior that was untested previously? What specific features of the resulting binary were untested previously/hidden behind this incorrect error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105210/new/

https://reviews.llvm.org/D105210