[PATCH] D105362: [NFC] Code cleanups in InlineCost.cpp.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 2 11:47:10 PDT 2021


mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:465
+  const int CostUpperBound =
+      std::numeric_limits<int>::max() - InlineConstants::InstrCost - 1;
   const bool ComputeFullInlineCost;
----------------
is INT_MAX used elsewhere in this file, or is numeric_limits used instead? basically, I'd stick to whatever is used in the file for consistency. If there's no consistency, I'd fix that in its own patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105362/new/

https://reviews.llvm.org/D105362



More information about the llvm-commits mailing list