[PATCH] D105338: [InstCombine] Revert "Temporarily do not drop volatile stores before unreachable"

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 2 09:53:32 PDT 2021


lebedev.ri added a comment.

In D105338#2855428 <https://reviews.llvm.org/D105338#2855428>, @nikic wrote:

> Ah yes, nothing as permanent as a temporary solution... Thanks for following up on this.
>
> Let's wait another week for a LangRef patch to appear, otherwise this LGTM.

BTW, i have already previously warned that this will happen 3 months after said patch landed,
and that was half a year ago: https://reviews.llvm.org/D87399#2472707
So sure, we can wait one more week, but somehow i'm not sure that'll get their attention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105338/new/

https://reviews.llvm.org/D105338



More information about the llvm-commits mailing list