[PATCH] D105332: [M68k][GloballSel] Lower outgoing return values in IRTranslator

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.h:177
 
+  CCAssignFn *getCCAssignFnForReturn(CallingConv::ID CC, bool Return,
+                                     bool IsVarArg) const;
----------------
Since there is the param `bool Return`, we could combine this function with the above one.


================
Comment at: llvm/test/CodeGen/M68k/GlobalISel/irtranslator-ret.ll:185
+  ; CHECK:   [[G_TRUNC1:%[0-9]+]]:_(s8) = G_TRUNC [[G_LOAD1]](s32)
+  ; CHECK:   $bd0 = COPY [[G_TRUNC1]](s8)
+  ; CHECK:   RTS implicit $bd0
----------------
The name of the register storing the return value, ie $bd0, could be turned into a regex. Please do the same for the tests below.


================
Comment at: llvm/test/CodeGen/M68k/GlobalISel/irtranslator-ret.ll:213
+  ret i64 %a
+}
----------------
Floating point tests might be doable? In case its a hastle and Minh does not mind, perhaps add a TODO in the IRTranslator somewhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105332/new/

https://reviews.llvm.org/D105332