[PATCH] D105343: [SimplifyCFG] Volatile memory operations do not trap

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 2 09:41:13 PDT 2021


lebedev.ri added a comment.

In D105343#2855407 <https://reviews.llvm.org/D105343#2855407>, @nikic wrote:

> This whole code doesn't really make sense. Can we switch it to isGuaranteedToTransferExecutionToSuccessor() (plus the volatile store exception)?

Yep, this code is really broken.
I'm intentionally not just doing that because i want to make the test diff smaller.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105343/new/

https://reviews.llvm.org/D105343



More information about the llvm-commits mailing list