[PATCH] D104630: [AArch64][CostModel] Add cost model for experimental.vector.splice

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 2 09:25:09 PDT 2021


CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added a comment.

Hey @david-arm 
So I knew about the getPromotedVTForPredicate, but was not sure it was a good idea to  use outside the class.
But as you suggested in the review, then I believe there is no problem in making it public.
I think it is best to have only one place to check the promoted type too.
But if not let me know and I can revert the change and apply your suggestion in the previous function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104630/new/

https://reviews.llvm.org/D104630



More information about the llvm-commits mailing list