[PATCH] D105072: [GISel] Support llvm.memcpy.inline

Fri Jul 2 08:42:59 PDT 2021

jroelofs added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir:632
 # DEBUG-NEXT: .. imm index coverage check SKIPPED: user-defined predicate detected
+# DEBUG-NEXT: G_MEMCPY_INLINE (opcode 219): 3 type indices, 0 imm indices
+# DEBUG-NEXT: .. type index coverage check SKIPPED: no rules defined
----------------
dyung wrote:
> In the future, please use a regex to match any number instead of hard coding a number in here as it causes the test to fail if a downstream copy has private changes which affect which number is assigned to this opcode.
> 
> I've fixed this up in f737d9794a40c066c9ccffb9ac277c1b70442ede.
Sorry about that. Thank you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105072/new/

https://reviews.llvm.org/D105072