[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

[Paulo Matos via Phabricator via llvm-commits]

pmatos added a comment.

In D104797#2854939 <https://reviews.llvm.org/D104797#2854939>, @lebedev.ri wrote:

> Reverted again
>
>   ********************
>   FAIL: LLVM :: CodeGen/WebAssembly/funcref-call.ll (44466 of 44468)
>   ******************** TEST 'LLVM :: CodeGen/WebAssembly/funcref-call.ll' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';   /builddirs/llvm-project/build-Clang12/bin/llc < /repositories/llvm-project/llvm/test/CodeGen/WebAssembly/funcref-call.ll --mtriple=wasm32-unknown-unknown -asm-verbose=false -mattr=+reference-types | /builddirs/llvm-project/build-Clang12/bin/FileCheck /repositories/llvm-project/llvm/test/CodeGen/WebAssembly/funcref-call.ll
>   --
>   Exit Code: 2
>   
>   Command Output (stderr):
>   --
>   llc: /repositories/llvm-project/llvm/include/llvm/Support/LowLevelTypeImpl.h:44: static llvm::LLT llvm::LLT::scalar(unsigned int): Assertion `SizeInBits > 0 && "invalid scalar size"' failed.
>
> Are you building llvm without assertions?

I am sorry - thanks for reverting.
Last time I tested with `check-all`, nothing was failing. Then I updated to `main` to commit but because `check-all` takes a while and I didn't want to miss the boat to push, I pushed the commit. 
However, the right procedure would have been probably to maybe run a quick `llvm-lit` on the WebAssembly tests. I didn't and between the main commit my patch was based on and current main `HEAD` a commit broke my patch again, specifically in sha 990278d026 <https://reviews.llvm.org/rG990278d026d680942c859be70836ad34a9a716f7>  (June 29).

I am now analysing this patch to reland, so I can fix mine once again and reland.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104797/new/

https://reviews.llvm.org/D104797