[PATCH] D103898: [VP] Vector predicated vector splice intrinsic

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

In D103898#2854635 <https://reviews.llvm.org/D103898#2854635>, @vkmr wrote:

> In D103898#2812522 <https://reviews.llvm.org/D103898#2812522>, @simoll wrote:
>
>> This patch needs to implement `VPIntrinsic::getDeclarationForParams`.
>
> for vp_splice, the implementation will be the same as the default case so I did not implement it explicitly. Did I miss anything?

You didn't. LGTM with nit.



================
Comment at: llvm/docs/LangRef.rst:18603
+The result and the first two arguments ``vec1`` and ``vec2`` are vectors with
+the same type.  The third argument ``imm`` is a signed integer that indicates
+the offset index.  The fourth argument ``mask`` is a vector mask and has the
----------------
I think it's not totally obvious that `%imm` has to be an immediate. Eg, you could add `immarg` in the intrinsic declarations (`Syntax` section) and mention it again in the `Arguments` section.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103898/new/

https://reviews.llvm.org/D103898