[PATCH] D105280: [2/2][RemoveRedundantDebugValues] Introduce a MIR pass that removes redundant DBG_VALUEs

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

In D105280#2853197 <https://reviews.llvm.org/D105280#2853197>, @djtodoro wrote:

> Actually, the `llvm-locstats` numbers will improve, since this fixes MIR, and `LiveDebugValues` will generate more entry-values for example, since the analysis generates entry-values for unmodified parameters, but with these duplicates, we have had a lot of false positives with the respect to param's changing (the pass considered a new/redundant `DBG_VALUE` as an assignment). I'll share the locstats numbers anyway.

Ah okay that makes sense. Thanks, I'd be interested to see those numbers.

Is the coverage boost expected to come from //only //entry-values then? If that's the case you could try a before/after comparison with entry-values disabled to check the NFC-ness (but it's not a requirement - up to you).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105280/new/

https://reviews.llvm.org/D105280