[PATCH] D105321: [Bitcode][OpaquePtr] Remove usages of PointerType's getElementType()

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 23:53:14 PDT 2021


nikic added a comment.

Can you please add some tests? Running some existing bitcode upgrade tests under `--force-opaque-pointers` should do it.

I don't really get how this is supposed to work. If opaque pointers are enabled, all PointerTypes (in the same address space) are going to be the same, so you can't create a meaningful map from PointerType to element type. The map will effectively store the last element type it has seen on any pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105321/new/

https://reviews.llvm.org/D105321



More information about the llvm-commits mailing list