[PATCH] D105288: [coro async] Cap the alignment of spilled values (vs. allocas) at the max frame alignment

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 21:52:55 PDT 2021


rjmccall added a comment.

Shouldn't there be a test case showing that a spilled value with high ABI alignment is placed in an appropriately-underaligned slot, and that the loads and stores to that slot have the necessary alignment?  Because the alignment in this test is just coming from the alloca's explicit alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105288/new/

https://reviews.llvm.org/D105288



More information about the llvm-commits mailing list