[PATCH] D105319: update_mir_test_checks.py: add a flag --use-first-common-prefix

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 21:25:01 PDT 2021


aemerson added a comment.

In D105319#2854423 <https://reviews.llvm.org/D105319#2854423>, @arsenm wrote:

> I don't think this should have an option. Ideally it would just be smart like update_llc_test_checks where it understands it expects identical output between the two cases

This makes it more convenient to at least update tests, and a final run of the tests will confirm if all the common checks were actually identical. Adding verification seems more work than I want to invest, so I'll leave it at that. I can also make it on by default too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105319/new/

https://reviews.llvm.org/D105319



More information about the llvm-commits mailing list