[PATCH] D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections

Thu Jul 1 20:58:28 PDT 2021

TaoPan added a comment.

In D101421#2854680 <https://reviews.llvm.org/D101421#2854680>, @rnk wrote:

> lgtm

Thanks for your big help!

================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2949
+  // non-primary basic block sections are not contiguous with primary basic
+  // block sectoin, don't emit relocation for non-prmiary (and non-contiguous)
+  // basic block sections.
----------------
rnk wrote:
> TaoPan wrote:
> > tmsriram wrote:
> > > Typo, "section" and "primary".  Similar comment rnk at .  The condition below only checks whether it is not the entry block but the comment says it is all non-primary basic blocks.
> > Thanks for pointing out the confuse comment! How about "The codeview line table format requires functions are contiguous, if function has BB sections, all MBBs have their own section, all sections are not contiguous, emit codeview relocation only for entry block MBB in this case."?
> Please fix the typo before committing.
I updated the comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101421/new/

https://reviews.llvm.org/D101421