[PATCH] D105330: [llvm-nm] Switch command line parsing from llvm::cl to OptTable

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added a reviewer: jhenderson.
Herald added subscribers: rupprecht, kristof.beyls, mgorny.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Some behavior changes:

- `-t=d` is removed. Use `-t d` instead.
- `--demangle=0` cannot be used. Omit the option or use `--no-demangle` instead.
- `--help-list` is removed. This is a `cl::` specific option.

Advantages:

- `-t` diagnostic gets improved.
- Avoid cl::opt collision if we decide to support multiplexing for binary utilities

Note:

- One-dash long options are still supported.
- The `-s` collision (`-s segment section` for Mach-O) is unfortunate. `-s` means `--print-armap` in GNU nm.
- This patch removes the last `cl::multi_val`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105330

Files:
  llvm/docs/CommandGuide/llvm-nm.rst
  llvm/test/Object/nm-universal-binary.test
  llvm/test/tools/llvm-nm/X86/radix.s
  llvm/test/tools/llvm-nm/format-bsd.test
  llvm/test/tools/llvm-nm/format-sysv-layout.test
  llvm/test/tools/llvm-nm/help.test
  llvm/test/tools/llvm-nm/just-symbols.test
  llvm/test/tools/llvm-nm/libtool-version.test
  llvm/tools/llvm-nm/CMakeLists.txt
  llvm/tools/llvm-nm/Opts.td
  llvm/tools/llvm-nm/llvm-nm.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105330.356087.patch
Type: text/x-patch
Size: 28984 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210702/adc337b8/attachment-0001.bin>