[PATCH] D105210: [lld-macho] Ignore debug symbols for now.

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/MachO/bug_50812.s:43-110
+      - sectname:        __eh_frame
+        segname:         __TEXT
+        addr:            0x0000000000000018
+        size:            64
+        offset:          0x000001D8
+        align:           3
+        reloff:          0x00000238
----------------
try and see if you can delete one or both of these sections and get yaml2obj to accept it. maybe that will also allow the test to pass w/o the Symbol referent changes being in this diff


================
Comment at: lld/test/MachO/bug_50812.s:117-129
+  - cmd:             LC_BUILD_VERSION
+    cmdsize:         32
+    platform:        1
+    minos:           720896
+    sdk:             721664
+    ntools:          1
+    Tools:
----------------
should be able to rm these (just remember to update `ncmds` above)

in general yaml test cases should be as small as possible. The goal is not to create a working binary, just to exercise the relevant LLD code paths


================
Comment at: lld/test/MachO/bug_50812.s:143
+    - n_strx:          26
+      n_type:          0x64
+      n_sect:          0
----------------
for clarity, can we add a ## comment on whichever symbols are N_STAB, and remove as many of the other symbols as possible?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105210/new/

https://reviews.llvm.org/D105210