[PATCH] D105210: [lld-macho] Ignore debug symbols for now.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked an inline comment as done and an inline comment as not done.
oontvoo added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:154-164
+    InputSection *rFuncIsec = nullptr;
+    if (rFunc.referent.is<Symbol *>()) {
+      assert(rFunc.referent.get<Symbol *>()->kind() ==
+             Symbol::Kind::DefinedKind);
+      rFuncIsec = cast<Defined>(rFunc.referent.get<Symbol *>())->isec;
+    } else {
+      assert(r.offset ==
----------------
int3 wrote:
> this should be in a separate diff, and also needs a test :)
Well, these are separate issue, yes, but without this change the link wouldn't succeed, ie., it'd trip on the assert on line 156 (on the LHS of the diff)
IOWs, all  of these changes are necessary for the test to pass 

Since these are small enough, can you just let put them in one diff :) 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105210/new/

https://reviews.llvm.org/D105210