[PATCH] D105210: [lld-macho] Ignore debug symbols for now.

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 15:22:16 PDT 2021


int3 added a comment.

Ah, `ld -r`... that bit us before in D104502: [lld-macho] Handle non-extern symbols marked as private extern <https://reviews.llvm.org/D104502> :)

> with a checked-in .o file, unless someone can tell me a way to produce it within the test

Let's use yaml2obj instead. Other LLVM tool tests use raw .o files sometimes, but I get the sense that it's a legacy decision and people are pushing back on further additions.

As a bonus, you can inline the YAML within the test file via `split-file --no-leading-lines`, see e.g. `dylink-ordinal.s`.



================
Comment at: lld/test/MachO/bug_50812.s:5
+
+# %lld -lSystem -platform_version macos 11.3 11.0 -arch x86_64  %S/Inputs/bug_50812.o
----------------
you're missing a RUN: here (which the test infra has rightly noted)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105210/new/

https://reviews.llvm.org/D105210



More information about the llvm-commits mailing list