[llvm] 4339d3b - Fix shared build.

[David Zarzycki via llvm-commits]

This broke -DLLVM_BUILD_LLVM_DYLIB=TRUE -DLLVM_LINK_LLVM_DYLIB=TRUE -DLLVM_DYLIB_COMPONENTS=all

Is there a more narrow fix we can do? For context:

FAIL: LLVM-Unit :: Passes/./PluginsTests/failed_to_discover_tests_from_gtest (70535 of 77558)
******************** TEST 'LLVM-Unit :: Passes/./PluginsTests/failed_to_discover_tests_from_gtest' FAILED ********************
Script:
--
/tmp/_update_lc/r/unittests/Passes/./PluginsTests --gtest_filter=failed_to_discover_tests_from_gtest
--
: CommandLine Error: Option 'help-list' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options




On Wed, Jun 30, 2021, at 2:05 PM, Michael Liao via llvm-commits wrote:
> 
> Author: Michael Liao
> Date: 2021-06-30T14:04:16-04:00
> New Revision: 4339d3bd84a9bc1b5ecc58ddfc935d53e9de4fd4
> 
> URL: 
> https://github.com/llvm/llvm-project/commit/4339d3bd84a9bc1b5ecc58ddfc935d53e9de4fd4
> DIFF: 
> https://github.com/llvm/llvm-project/commit/4339d3bd84a9bc1b5ecc58ddfc935d53e9de4fd4.diff
> 
> LOG: Fix shared build.
> 
> Added: 
>     
> 
> Modified: 
>     llvm/unittests/Passes/CMakeLists.txt
> 
> Removed: 
>     
> 
> 
> ################################################################################
> diff  --git a/llvm/unittests/Passes/CMakeLists.txt 
> b/llvm/unittests/Passes/CMakeLists.txt
> index 075b47c8d07e6..7c09053c7ab16 100644
> --- a/llvm/unittests/Passes/CMakeLists.txt
> +++ b/llvm/unittests/Passes/CMakeLists.txt
> @@ -17,7 +17,7 @@ if (NOT WIN32)
>      PluginsTest.cpp
>      )
>    export_executable_symbols_for_plugins(PluginsTests)
> -  target_link_libraries(PluginsTests PRIVATE LLVMTestingSupport)
> +  target_link_libraries(PluginsTests PRIVATE LLVMAsmParser 
> LLVMTestingSupport)
>  
>    set(LLVM_LINK_COMPONENTS)
>    foreach(PLUGIN TestPlugin DoublerPlugin)
> 
> 
>         
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>