[PATCH] D105309: [InstCombine] Don't combine PHI before catchswitch

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

This is seems like a too heavy hammer.
`foldPHIArgZextsIntoPHI()` has:

  // We cannot create a new instruction after the PHI if the terminator is an
  // EHPad because there is no valid insertion point.
  if (Instruction *TI = Phi.getParent()->getTerminator())
    if (TI->isEHPad())
      return nullptr;

Is that the same check as here? (which means that the check here is incomplete?)
If yes, then can you add a similar check to whatever fold is missing it, specifically?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105309/new/

https://reviews.llvm.org/D105309