[PATCH] D105310: Mark SRet argument as pointer in SelectionDAGISel::LowerArguments

James Nagurne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 12:48:04 PDT 2021


JamesNagurne created this revision.
JamesNagurne added a project: LLVM.
Herald added a subscriber: hiraditya.
JamesNagurne requested review of this revision.
Herald added a subscriber: llvm-commits.

Mark SRet argument as pointer in SelectionDAGISel::LowerArguments

      

When the concept of pointers was added to ArgFlagsTy, lowered SRet
arguments were not marked as pointers.

      

I don't think this affects any upstream target, but the flag should still
be set for consistency.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105310

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp


Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -10046,6 +10046,7 @@
     // or one register.
     ISD::ArgFlagsTy Flags;
     Flags.setSRet();
+    Flags.setPointer();
     MVT RegisterVT = TLI->getRegisterType(*DAG.getContext(), ValueVTs[0]);
     ISD::InputArg RetArg(Flags, RegisterVT, ValueVTs[0], true,
                          ISD::InputArg::NoArgIndex, 0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105310.355982.patch
Type: text/x-patch
Size: 566 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210701/5bec237e/attachment.bin>


More information about the llvm-commits mailing list