[PATCH] D105258: [llvm-readobj][MachO] Support option --unwind for __eh_frame

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D105258#2853837 <https://reviews.llvm.org/D105258#2853837>, @gkm wrote:

> In D105258#2852740 <https://reviews.llvm.org/D105258#2852740>, @thakis wrote:
>
>> That looks ok, but doesn't `llvm-dwarfdump --eh-frame file` do this already?
>
> Ah yes, though the function addresses printed as `pc=...` are wrong. I will file a bug.

I think they're correct (?) They used to be wrong, but they seem to be fine now, at least in the examples I looked at – see unwinfo.py output here https://bugs.llvm.org/show_bug.cgi?id=50956 and comments about llvm-dwarfdump here https://github.com/nico/hack/blob/master/unwinfo.py#L63

> The ultimate goal with `llvm-readobj` is to dump any & all of `__eh_frame`, `__compact_unwind`, and `__unwind_info`, whereas the latter two are beyond the scope of `llvm-dwarfdump`.

Yes, I think that's a good goal. There isn't a great way to do get a combined view at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105258/new/

https://reviews.llvm.org/D105258