[PATCH] D105305: [lld-macho] Factor out common InputSection members

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 12:09:49 PDT 2021


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: lld/MachO/InputSection.h:147
 
+static_assert(sizeof(ConcatInputSection) == 112,
+              "Try to minimize ConcatInputSection's size, we create many "
----------------
This might fail in 32-bit builds -- probably want to do `<=` for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105305/new/

https://reviews.llvm.org/D105305



More information about the llvm-commits mailing list