[PATCH] D105298: [InstSimplify] do not propagate poison from select arm to icmp user

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D105298#2853512 <https://reviews.llvm.org/D105298#2853512>, @efriedma wrote:

> I'm skeptical it's correct to explicitly check for PoisonValue here.  Does it matter if the value is poison, but not a poison literal?  Does it matter if a constant vector has a poison element?

Yes, good point. We want to use isGuaranteedNotToBePoison() to be safe IIUC.
I've been trying to find a hole through other folds that would show that difference, but I haven't found one yet...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105298/new/

https://reviews.llvm.org/D105298