[PATCH] D100670: [ADT] Add makeVisitor to STLExtras.h

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 11:06:08 PDT 2021 

scott.linder added a comment.

In D100670#2853327 <https://reviews.llvm.org/D100670#2853327>, @stella.stamenova wrote:

> A couple of the new test cases are consistently failing on Windows when building Debug. They do pass in Release
>
>   2021-07-01T09:35:59.0150364Z -- Testing: 76257 tests, 32 workers --
>   2021-07-01T10:01:33.7697594Z Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80..
>   2021-07-01T10:01:33.7699468Z FAIL: LLVM-Unit :: ADT/./ADTTests.exe/STLExtrasTest.MakeVisitorDefaultCase (67224 of 76257)
>   2021-07-01T10:01:33.7701921Z ******************** TEST 'LLVM-Unit :: ADT/./ADTTests.exe/STLExtrasTest.MakeVisitorDefaultCase' FAILED ********************
>   2021-07-01T10:01:33.7705176Z Script:
>   2021-07-01T10:01:33.7707482Z --
>   2021-07-01T10:01:33.7708449Z D:\a\_work\1\b\llvm\Debug\unittests\ADT\.\ADTTests.exe --gtest_filter=STLExtrasTest.MakeVisitorDefaultCase
>   2021-07-01T10:01:33.7710536Z --
>   2021-07-01T10:01:33.7711290Z Note: Google Test filter = STLExtrasTest.MakeVisitorDefaultCase
>   2021-07-01T10:01:33.7711592Z 
>   2021-07-01T10:01:33.7712142Z [==========] Running 1 test from 1 test suite.
>   2021-07-01T10:01:33.7712386Z 
>   2021-07-01T10:01:33.7712823Z [----------] Global test environment set-up.
>   2021-07-01T10:01:33.7713592Z 
>   2021-07-01T10:01:33.7717503Z [----------] 1 test from STLExtrasTest
>   2021-07-01T10:01:33.7718505Z 
>   2021-07-01T10:01:33.7720213Z [ RUN      ] STLExtrasTest.MakeVisitorDefaultCase
>   2021-07-01T10:01:33.7720490Z 
>   2021-07-01T10:01:33.7721127Z D:\a\_work\1\s\llvm\unittests\ADT\STLExtrasTest.cpp(799): error: Expected equality of these values:
>   2021-07-01T10:01:33.7721574Z 
>   2021-07-01T10:01:33.7721953Z   Visitor(2.)
>   2021-07-01T10:01:33.7722097Z 
>   2021-07-01T10:01:33.7722524Z     Which is: 00007FF724E66A30
>   2021-07-01T10:01:33.7722710Z 
>   2021-07-01T10:01:33.7723131Z   "unhandled type"
>   2021-07-01T10:01:33.7723283Z 
>   2021-07-01T10:01:33.7723697Z     Which is: 00007FF724E53048
>   2021-07-01T10:01:33.7723881Z 
>   2021-07-01T10:01:33.7724532Z D:\a\_work\1\s\llvm\unittests\ADT\STLExtrasTest.cpp(800): error: Expected equality of these values:
>   2021-07-01T10:01:33.7724903Z 
>   2021-07-01T10:01:33.7725284Z   Visitor(Visitor)
>   2021-07-01T10:01:33.7725438Z 
>   2021-07-01T10:01:33.7725887Z     Which is: 00007FF724E66A30
>   2021-07-01T10:01:33.7726076Z 
>   2021-07-01T10:01:33.7726464Z   "unhandled type"
>   2021-07-01T10:01:33.7726655Z 
>   2021-07-01T10:01:33.7727072Z     Which is: 00007FF724E530C8
>   2021-07-01T10:01:33.7727802Z 
>   2021-07-01T10:01:33.7728452Z D:\a\_work\1\s\llvm\unittests\ADT\STLExtrasTest.cpp(808): error: Expected equality of these values:
>   2021-07-01T10:01:33.7729535Z 
>   2021-07-01T10:01:33.7730317Z   Visitor(2.)
>   2021-07-01T10:01:33.7730682Z 
>   2021-07-01T10:01:33.7731329Z     Which is: 00007FF724E66A30
>   2021-07-01T10:01:33.7731592Z 
>   2021-07-01T10:01:33.7732027Z   "unhandled type"
>   2021-07-01T10:01:33.7732182Z 
>   2021-07-01T10:01:33.7732641Z     Which is: 00007FF724E531E0
>   2021-07-01T10:01:33.7732826Z 
>   2021-07-01T10:01:33.7733469Z D:\a\_work\1\s\llvm\unittests\ADT\STLExtrasTest.cpp(809): error: Expected equality of these values:
>   2021-07-01T10:01:33.7733845Z 
>   2021-07-01T10:01:33.7734228Z   Visitor(Visitor)
>   2021-07-01T10:01:33.7734407Z 
>   2021-07-01T10:01:33.7735018Z     Which is: 00007FF724E66A30
>   2021-07-01T10:01:33.7735513Z 
>   2021-07-01T10:01:33.7736034Z   "unhandled type"
>   2021-07-01T10:01:33.7736306Z 
>   2021-07-01T10:01:33.7736778Z     Which is: 00007FF724E53258
>   2021-07-01T10:01:33.7737025Z 
>   2021-07-01T10:01:33.7739580Z [  FAILED  ] STLExtrasTest.MakeVisitorDefaultCase (2 ms)
>   2021-07-01T10:01:33.7739859Z 
>   2021-07-01T10:01:33.7740503Z [----------] 1 test from STLExtrasTest (2 ms total)
>   2021-07-01T10:01:33.7740744Z 
>   2021-07-01T10:01:33.7740854Z 
>   2021-07-01T10:01:33.7740961Z 
>   2021-07-01T10:01:33.7741379Z [----------] Global test environment tear-down
>   2021-07-01T10:01:33.7741628Z 
>   2021-07-01T10:01:33.7742090Z [==========] 1 test from 1 test suite ran. (2 ms total)
>   2021-07-01T10:01:33.7742296Z 
>   2021-07-01T10:01:33.7742663Z [  PASSED  ] 0 tests.
>   2021-07-01T10:01:33.7742832Z 
>   2021-07-01T10:01:33.7743244Z [  FAILED  ] 1 test, listed below:
>   2021-07-01T10:01:33.7743439Z 
>   2021-07-01T10:01:33.7743884Z [  FAILED  ] STLExtrasTest.MakeVisitorDefaultCase
>   2021-07-01T10:01:33.7744073Z 
>   2021-07-01T10:01:33.7744183Z 
>   2021-07-01T10:01:33.7744290Z 
>   2021-07-01T10:01:33.7744639Z  1 FAILED TEST
>   2021-07-01T10:01:33.7744812Z 
>   2021-07-01T10:01:33.7744922Z 
>   2021-07-01T10:01:33.7745284Z ********************
>   2021-07-01T10:01:33.7903181Z Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80..
>   2021-07-01T10:01:33.8009590Z FAIL: LLVM-Unit :: ADT/./ADTTests.exe/STLExtrasTest.MakeVisitorTwoCallables (67229 of 76257)
>   2021-07-01T10:01:33.8011983Z ******************** TEST 'LLVM-Unit :: ADT/./ADTTests.exe/STLExtrasTest.MakeVisitorTwoCallables' FAILED ********************
>   2021-07-01T10:01:33.8029530Z Script:
>   2021-07-01T10:01:33.8061592Z --
>   2021-07-01T10:01:33.8062299Z D:\a\_work\1\b\llvm\Debug\unittests\ADT\.\ADTTests.exe --gtest_filter=STLExtrasTest.MakeVisitorTwoCallables
>   2021-07-01T10:01:33.8062912Z --
>   2021-07-01T10:01:33.8063391Z Note: Google Test filter = STLExtrasTest.MakeVisitorTwoCallables
>   2021-07-01T10:01:33.8063636Z 
>   2021-07-01T10:01:33.8064103Z [==========] Running 1 test from 1 test suite.
>   2021-07-01T10:01:33.8064308Z 
>   2021-07-01T10:01:33.8064738Z [----------] Global test environment set-up.
>   2021-07-01T10:01:33.8065209Z 
>   2021-07-01T10:01:33.8065628Z [----------] 1 test from STLExtrasTest
>   2021-07-01T10:01:33.8065845Z 
>   2021-07-01T10:01:33.8066280Z [ RUN      ] STLExtrasTest.MakeVisitorTwoCallables
>   2021-07-01T10:01:33.8066511Z 
>   2021-07-01T10:01:33.8067118Z D:\a\_work\1\s\llvm\unittests\ADT\STLExtrasTest.cpp(781): error: Expected equality of these values:
>   2021-07-01T10:01:33.8067483Z 
>   2021-07-01T10:01:33.8068073Z   Visitor(42)
>   2021-07-01T10:01:33.8068229Z 
>   2021-07-01T10:01:33.8068651Z     Which is: 00007FF724E66994
>   2021-07-01T10:01:33.8068833Z 
>   2021-07-01T10:01:33.8069212Z   "int"
>   2021-07-01T10:01:33.8069387Z 
>   2021-07-01T10:01:33.8069800Z     Which is: 00007FF724E51D5C
>   2021-07-01T10:01:33.8070133Z 
>   2021-07-01T10:01:33.8070722Z D:\a\_work\1\s\llvm\unittests\ADT\STLExtrasTest.cpp(782): error: Expected equality of these values:
>   2021-07-01T10:01:33.8071077Z 
>   2021-07-01T10:01:33.8071466Z   Visitor("foo")
>   2021-07-01T10:01:33.8071646Z 
>   2021-07-01T10:01:33.8072206Z     Which is: 00007FF724E66998
>   2021-07-01T10:01:33.8072395Z 
>   2021-07-01T10:01:33.8072764Z   "str"
>   2021-07-01T10:01:33.8073016Z 
>   2021-07-01T10:01:33.8073418Z     Which is: 00007FF724E51D94
>   2021-07-01T10:01:33.8073593Z 
>   2021-07-01T10:01:33.8074050Z [  FAILED  ] STLExtrasTest.MakeVisitorTwoCallables (0 ms)
>   2021-07-01T10:01:33.8074268Z 
>   2021-07-01T10:01:33.8074693Z [----------] 1 test from STLExtrasTest (0 ms total)
>   2021-07-01T10:01:33.8074919Z 
>   2021-07-01T10:01:33.8075033Z 
>   2021-07-01T10:01:33.8075144Z 
>   2021-07-01T10:01:33.8075553Z [----------] Global test environment tear-down
>   2021-07-01T10:01:33.8075771Z 
>   2021-07-01T10:01:33.8076204Z [==========] 1 test from 1 test suite ran. (2 ms total)
>   2021-07-01T10:01:33.8076417Z 
>   2021-07-01T10:01:33.8076786Z [  PASSED  ] 0 tests.
>   2021-07-01T10:01:33.8076958Z 
>   2021-07-01T10:01:33.8077371Z [  FAILED  ] 1 test, listed below:
>   2021-07-01T10:01:33.8077568Z 
>   2021-07-01T10:01:33.8078005Z [  FAILED  ] STLExtrasTest.MakeVisitorTwoCallables
>   2021-07-01T10:01:33.8078209Z 
>   2021-07-01T10:01:33.8078330Z 
>   2021-07-01T10:01:33.8078459Z 
>   2021-07-01T10:01:33.8078817Z  1 FAILED TEST
>   2021-07-01T10:01:33.8080335Z 
>   2021-07-01T10:01:33.8080521Z 
>   2021-07-01T10:01:33.8081113Z ********************
>   2021-07-01T10:02:59.3969341Z Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
>   2021-07-01T10:02:59.7189730Z 
>   2021-07-01T10:02:59.7190464Z 1 warning(s) in tests
>   2021-07-01T10:02:59.7711389Z ********************
>   2021-07-01T10:02:59.7713124Z Failed Tests (2):
>   2021-07-01T10:02:59.7713692Z   LLVM-Unit :: ADT/./ADTTests.exe/STLExtrasTest.MakeVisitorDefaultCase
>   2021-07-01T10:02:59.7714235Z   LLVM-Unit :: ADT/./ADTTests.exe/STLExtrasTest.MakeVisitorTwoCallables
>   2021-07-01T10:02:59.7714448Z 
>   2021-07-01T10:02:59.7714545Z 
>   2021-07-01T10:02:59.7714906Z Testing Time: 1646.03s
>   2021-07-01T10:02:59.7715299Z   Skipped          :    39
>   2021-07-01T10:02:59.7715766Z   Unsupported      : 21785
>   2021-07-01T10:02:59.7716168Z   Passed           : 54327
>   2021-07-01T10:02:59.7716570Z   Expectedly Failed:   104
>   2021-07-01T10:02:59.7717012Z   Failed           :     2

Looking at this now, if I can't root cause quickly I will revert again


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100670/new/

https://reviews.llvm.org/D100670

More information about the llvm-commits mailing list