[PATCH] D105272: [CMake][MLIR][Linalg] Adding variable to specify tablegen file dependencies.

[Stella Laurenzo via Phabricator via llvm-commits]

stellaraccident accepted this revision.
stellaraccident added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt:28
     ${GEN_ODS_FILE} ${GEN_CPP_FILE})
+  set(LLVM_TARGET_DEPENDS ${LLVM_TARGET_DEPENDS} ${GEN_ODS_FILE} PARENT_SCOPE)
 endfunction()
----------------
Can you add a Todo that when this function is rewritten and the old tc parser is retired, to eliminate the parent scope manipulation and do the tablegen generation here in this scope?

I really don't like this action at a distance manipulation of something like a dependency. But since it is all in the same file, in an intermediate state, and I know you are getting ready to delete the old so this can be reworked, I'll favor submitting in this way to fix the incremental build issue.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/CMakeLists.txt:61
 # ported.
+set(LLVM_TARGET_DEPENDS "")
 add_linalg_ods_tc_gen(LinalgNamedStructuredOpsSpec.tc LinalgNamedStructuredOps)
----------------
Add a Todo here to factor this so that resetting the var like this is not required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105272/new/

https://reviews.llvm.org/D105272