[PATCH] D105290: [GISel] Print better error messages for missing Combiner Observer calls

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 08:27:40 PDT 2021


jroelofs added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CSEInfo.cpp:285
       return createStringError(std::errc::not_supported,
-                               "Node in CSE without InstrMapping", UMI.MI);
 
----------------
The 3rd param was silently useless here, since the format string doesn't have a placeholder for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105290/new/

https://reviews.llvm.org/D105290



More information about the llvm-commits mailing list