[PATCH] D103326: [GlobalISel] Add combine for PTR_ADD with regbanks

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 1 03:52:50 PDT 2021


sebastian-ne updated this revision to Diff 355824.
sebastian-ne marked 2 inline comments as done.
sebastian-ne added a comment.

> Why use an optional ID, instead of just a RegisterBank pointer that may be null?

Good point, now using a pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103326/new/

https://reviews.llvm.org/D103326

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
  llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCombine.td
  llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement-stack-lower.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/insertelement.large.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103326.355824.patch
Type: text/x-patch
Size: 112844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210701/ee0f85a3/attachment-0001.bin>


More information about the llvm-commits mailing list