[PATCH] D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@chrisjackson thanks for working on this!

(I've just started looking into this, so I've included a few nits for now.)



================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:5850
 
-using EqualValues = SmallVector<std::tuple<WeakVH, int64_t>, 4>;
-using EqualValuesMap =
-    DenseMap<DbgValueInst *, SmallVector<std::pair<unsigned, EqualValues>>>;
-using LocationMap =
-    DenseMap<DbgValueInst *, std::pair<DIExpression *, Metadata *>>;
+struct SCEVDbgBuilder {
+  SCEVDbgBuilder(){};
----------------
`SCEVDbgValueBuilder` instead?


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:5851
+struct SCEVDbgBuilder {
+  SCEVDbgBuilder(){};
+  SCEVDbgBuilder(const SCEVDbgBuilder &Base) {
----------------
SCEVDbgBuilder() = default;


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:5917
+                                   : llvm::dwarf::DW_ATE_unsigned};
+    for (auto Op : CastOps)
+      pushOperator(Op);
----------------
`const auto&` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105207/new/

https://reviews.llvm.org/D105207