[PATCH] D105249: [llvm-strip] Support grouped options in llvm-strip
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 1 00:49:09 PDT 2021
jhenderson added a comment.
Does it make sense to do this for llvm-objcopy at the same time? My quick testing suggests GNU objcopy accepts grouped options, but llvm-objcopy doesn't, at least for the version I've got on my machine.
================
Comment at: llvm/test/tools/llvm-objcopy/grouped-options.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-strip -S -x -o %t-separated %t
----------------
Add a brief top-level comment to the test explaining the purpose of the test.
================
Comment at: llvm/test/tools/llvm-objcopy/grouped-options.test:47
+ Binding: STB_GLOBAL
+
----------------
Nit: delete the extra trailing blank line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105249/new/
https://reviews.llvm.org/D105249
More information about the llvm-commits
mailing list