[PATCH] D104751: Unpack the CostEstimate feature in ML inlining models.

[Jacob Hegna via Phabricator via llvm-commits]

jacobhegna updated this revision to Diff 355774.
jacobhegna added a comment.

Forgot to name the constants - now added.

One thing to note is the getExpectedNumberOfCompare function. Because the same
math is used in both visitors, I abstracted it and moved the relevant comment.
Just want to double check that you think that's ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104751/new/

https://reviews.llvm.org/D104751

Files:
  llvm/include/llvm/Analysis/InlineCost.h
  llvm/include/llvm/Analysis/InlineModelFeatureMaps.h
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/InlineCost.cpp
  llvm/lib/Analysis/MLInlineAdvisor.cpp
  llvm/lib/Analysis/models/inlining/config.py
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/unittests/Analysis/InlineCostTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104751.355774.patch
Type: text/x-patch
Size: 24789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210701/ac6ce5ea/attachment.bin>