[PATCH] D105044: [lld-macho] Move ICF earlier to avoid emitting redundant binds

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:988
+          }
+          isec->outSecOff = ++inputOrder;
+          inputSections.push_back(isec);
----------------
oontvoo wrote:
> why not leave it as 0-based rather than 1?
> 
> not saying it's wrong ...  just curious :) 
well some reviewers seem to dislike post-increments :)

either a zero- or 1-based index works here, but yeah, maybe keeping it zero-based will be less surprising. I'll change it back


================
Comment at: lld/MachO/UnwindInfoSection.cpp:133
+    : SyntheticSection(segment_names::text, section_names::unwindInfo) {
+  align = 4;
+  compactUnwindSection =
----------------
oontvoo wrote:
> why "4"?  is this not platform dependent?
this is existing code, I think @gkm wrote this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105044/new/

https://reviews.llvm.org/D105044