[PATCH] D90051: AMDGPU/GlobalISel: Add floating point med3 combine

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 18:03:11 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegBankCombiner.cpp:179
+
+  const APFloat &KO_FPImm = getConstantFPVRegVal(K0, MRI)->getValue();
+  const APFloat &K1_FPImm = getConstantFPVRegVal(K1, MRI)->getValue();
----------------
Like in the other patches, why do you need to re-query getConstantFPVRegVal? Why doesn't the constant matcher just directly return the constant?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90051/new/

https://reviews.llvm.org/D90051



More information about the llvm-commits mailing list