[PATCH] D105248: [CSSPGO] Do not import pseudo probe desc in thinLTO

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 16:55:53 PDT 2021


hoy created this revision.
Herald added subscribers: ormris, modimo, wenlei, steven_wu, hiraditya, inglorion.
hoy requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously we reliedy on pseudo probe descriptors to look up precomputed GUID during probe emission for inlined probes. Since we are moving to always using unique linkage names, GUID for functions can be computed in place from dwarf names. This eliminates the need of importing pseudo probe descs in thinlto, since those descs should be emitted by the original modules.

This significantly reduces thinlto memory footprint in some extreme case where the number of imported modules for a single module is massive.

Test Plan:


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105248

Files:
  llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp
  llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.h
  llvm/lib/Linker/IRMover.cpp
  llvm/test/ThinLTO/X86/Inputs/pseudo-probe-desc-import.ll
  llvm/test/ThinLTO/X86/pseudo-probe-desc-import.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105248.355728.patch
Type: text/x-patch
Size: 6437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210630/4c6ad5e5/attachment.bin>


More information about the llvm-commits mailing list