[PATCH] D105176: [InstrProfiling] Use external linkage for bias variable

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:698
+        if (TT.supportsCOMDAT())
+            Bias->setComdat(M->getOrInsertComdat(Bias->getName()));
       }
----------------
mcgrathr wrote:
> What's the meaning of comdat on an undefined external?
> There is no such concept at the object file level, at least not in ELF.
> 
The variable is defined (it has an initialization).

The related question is that without COMDAT support, would this leads to multiple definition linker error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105176/new/

https://reviews.llvm.org/D105176