[PATCH] D105245: [Bazel] Update README with examples
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 30 16:28:22 PDT 2021
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM, two minor suggestions below.
================
Comment at: utils/bazel/examples/submodule/WORKSPACE:5
+
+"""An example WORKSPACE for configuring LLVM using http_archive."""
+
----------------
This should be `using a git submodule.` I would guess?
================
Comment at: utils/bazel/examples/submodule/WORKSPACE:8
+workspace(name = "submodule_example")
+
+SUBMODULE_PATH = "third_party/llvm-project"
----------------
Maybe a comment clarifying that this isn't constrained?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105245/new/
https://reviews.llvm.org/D105245
More information about the llvm-commits
mailing list