[PATCH] D105217: [LLD] Adding support for RELA for CG Profile.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: lld/ELF/Driver.cpp:869
 template <class ELFT> static void readCallGraphsFromObjectFiles() {
-  auto getIndex = [&](ObjFile<ELFT> *obj, uint32_t index) {
-    const Elf_Rel_Impl<ELFT, false> &rel = obj->cgProfileRel[index];
-    return rel.getSymbol(config->isMips64EL);
-  };
+  SmallVector<uint32_t, 128> symbolIndices;
 
----------------
modimo wrote:
> I don't think you need this vector, the getIndex lambda can be generalized as a templated lambda/function based on ArrayRef
I wanted to doing a rel/rela check on each invocation of helper function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105217/new/

https://reviews.llvm.org/D105217