[PATCH] D104542: [M68k][GloballSel] Formal arguments lowering in IRTranslator

Sushma Unnibhavi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 10:34:18 PDT 2021


sushmaunnibhavi added inline comments.


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kCallLowering.cpp:81
+  // define a lambda expression to load value
+  auto BuildLoad = [](MachineIRBuilder &MIRBuilder, MachinePointerInfo &MPO,
+                      uint64_t Size, const DstOp &Res, Register Addr) {
----------------
myhsu wrote:
> Is there any specific reason to extract these code into a separate lambda if there is only one callsite
Yeah, this isn't necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104542/new/

https://reviews.llvm.org/D104542



More information about the llvm-commits mailing list