[PATCH] D104542: [M68k][GloballSel] Formal arguments lowering in IRTranslator

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kCallLowering.cpp:81
+  // define a lambda expression to load value
+  auto BuildLoad = [](MachineIRBuilder &MIRBuilder, MachinePointerInfo &MPO,
+                      uint64_t Size, const DstOp &Res, Register Addr) {
----------------
Is there any specific reason to extract these code into a separate lambda if there is only one callsite


================
Comment at: llvm/test/CodeGen/M68k/GlobalISel/irtranslator-ret.ll:15
+  ; CHECK: bb.1 (%ir-block.0):
+  ; CHECK:   [[G_F_I1:%[0-9]+]]:_(p0) = G_FRAME_INDEX 
+  ; CHECK:   [[G_LOAD1:%[0-9]+]]:_(s32) = G_LOAD [[G_F_I1]](p0)
----------------
Git told me that there are trailing white spaces after every `G_FRAME_INDEX` line in this file, please remove them


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104542/new/

https://reviews.llvm.org/D104542