[PATCH] D105075: [lld-macho] Only emit one BIND_OPCODE_SET_SYMBOL per symbol
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 30 08:56:11 PDT 2021
thakis added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:357
+ std::vector<std::pair<const Sym *, std::vector<BindingEntry>>> bindingsVec(
+ bindingsMap.begin(), bindingsMap.end());
+ for (auto &p : bindingsVec) {
----------------
Is it guaranteed that we have filtered out separate symbols pointing at the same address by now? If not, this has nondeterminism issues (here and in the sort below)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105075/new/
https://reviews.llvm.org/D105075
More information about the llvm-commits
mailing list