[PATCH] D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests

Maryam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 07:34:00 PDT 2021


MaryamBen marked an inline comment as done.
MaryamBen added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:89
 ; CHECKSYM-NEXT:       StorageMappingClass: XMC_PR (0x0)
-; CHECKSYM-NEXT:       StabInfoIndex: 0x0
-; CHECKSYM-NEXT:       StabSectNum: 0x0
+; CHECKSYM32:          StabInfoIndex: 0x0
+; CHECKSYM32-NEXT:     StabSectNum: 0x0
----------------
jhenderson wrote:
> Here and everywhere else you've used `CHECKSYM32` or `CHECKSYM64` - should they be `CHECKSYM32-NEXT` and `CHECKSYM64-NEXT`?
> 
> Same goes in other similar cases - make sure you to use the -NEXT suffix wherever possible.
Thank you, I applied this to all the patchs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104644/new/

https://reviews.llvm.org/D104644



More information about the llvm-commits mailing list